Skip to content

Commit

Permalink
Restricts the protobuf dependency to be < 5.0.0, due to a recent brea…
Browse files Browse the repository at this point in the history
…king change. (tensorflow#6814)

The protobuf release 5.26.x is the first one in the major version 5,
which introduces a breaking change.

This change adds a restriction on that dependency. See tensorflow#6808 for
details.
  • Loading branch information
arcra authored and AnuarTB committed May 3, 2024
1 parent 5f1ff61 commit 6b77522
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tensorboard/pip_package/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ numpy >= 1.12.0
# https://github.com/tensorflow/tensorflow/blob/25adc4fccb4b0bb5a933eba1d246380e7b87d7f7/tensorflow/tools/pip_package/setup.py#L101
# 4.24.0 had an issue that broke our tests, so we should avoid that release:
# https://github.com/protocolbuffers/protobuf/issues/13485
protobuf >= 3.19.6, != 4.24.0
# 5.26.0 introduced a breaking change, so we restricted it for now. See issue #6808 for details.
protobuf >= 3.19.6, != 4.24.0, < 5.0.0
setuptools >= 41.0.0 # Note: provides pkg_resources as well as setuptools
# A dependency of our vendored packages. This lower bound has not been correctly
# vetted, but I wanted to be the least restrictive we can, since it's not a new
Expand Down

0 comments on commit 6b77522

Please sign in to comment.