Use separated exit codes for each type of errors

README.md

@@ -101,9 +101,16 @@ Options:
   -d, --delete   Delete an existing alias  
   -h, --help     Display this message and exit  
   -V, --version  Display version information and exit  
+
+Exit Codes:
+  0  OK
+  1  Invalid argument/option
+  2  User didn't gave the confirmation to proceed
+  3  An error occured when creating/restoring the backup of the .bashrc file
+  4  An error occured when adding/removing the alias
+```
 
 For more information, see the malias(1) man page
-```
 
 ## Contributing
 

doc/man/malias.1

@@ -39,14 +39,26 @@ Print the current version.
 .B \-h, \-\-help
 Print the help.
 
-.SH EXIT STATUS
+.SH EXIT CODES
 .TP
 .B 0
-if OK
+OK
 
 .TP
 .B 1
-if problems (user didn't gave confirmation to proceed with the adding/deletion, a problem happened during the backup/restore process of the .bashrc file, the added alias is incorrect, ...)
+Invalid argument/option
+
+.TP
+.B 2
+User didn't gave the confirmation to proceed
+
+.TP
+.B 3
+An error occured when creating/restoring the backup of the .bashrc file
+
+.TP
+.B 4
+An error occured when adding/removing the alias
 
 .SH USAGE
 .TP

src/script/malias.sh

@@ -35,7 +35,7 @@ version() {
 
 # Definition of the invalid_argument function: Print an error message, ask the user to check the help and exit
 invalid_argument() {
-	echo -e >&2 "${name}: invalid argument -- '${operation}'\nTry '${name} --help' for more information."
+	echo -e >&2 "${name}: invalid argument -- '${argument}'\nTry '${name} --help' for more information."
 	exit 1
 }
 
@@ -55,10 +55,10 @@ help    (Print the help)
 quit    (Quit Malias)
 EOF
 
-	read -rp $'\nWhat operation do you want to do? ' operation
-	operation=$(echo "${operation}" | awk '{print tolower($0)}')
+	read -rp $'\nWhat operation do you want to do? ' argument
+	argument=$(echo "${argument}" | awk '{print tolower($0)}')
 
-	case "${operation}" in
+	case "${argument}" in
 		a|add)
 			argument="--add"
 		;;
@@ -98,11 +98,17 @@ add() {
 		;;
 		*)
 			echo -e >&2 "\nAborting"
-			exit 1
+			exit 2
 		;;
 	esac
 
-	cp -p ~/.bashrc ~/.bashrc-bck_${name}-add-"${alias_name}"-"$(date +"%d-%m-%Y")" && echo -e "\nBackup of the .bashrc file created" || exit 1
+	if cp -p ~/.bashrc ~/.bashrc-bck_${name}-add-"${alias_name}"-"$(date +"%d-%m-%Y")"; then
+		echo -e "\nBackup of the .bashrc file created"
+	else
+		echo -e >&2 "ERROR: An error occured when creating the backup of the .bashrc file"
+		exit 3
+	fi
+
 	echo "alias ${new_alias}" >> ~/.bashrc
 
 	source_error=$(bash -x ~/.bashrc 2>/dev/null; echo $?)
@@ -112,9 +118,14 @@ add() {
 		rm -f ~/.bashrc-bck_${name}-add-"${alias_name}"-"$(date +"%d-%m-%Y")" && echo "Backup of the .bashrc file deleted"
 		exec bash
 	else
-		echo -e >&2 "\nERROR: An error occured when applying the alias\nPlease verify that you typed the alias correctly\nAlso, be aware that the alias name cannot contain space(s). However, it can contain \"-\" (hyphen) or \"_\" (underscore)"
-		mv -f ~/.bashrc-bck_${name}-add-"${alias_name}"-"$(date +"%d-%m-%Y")" ~/.bashrc && echo "Backup of the .bashrc file restored" || echo -e >&2 "\nERROR: An error occurred when restoring the backup of the ~/.bashrc file\nPlease, check for potential errors in it"
-		exit 1
+		echo -e >&2 "\nERROR: An error occured when adding the alias\nPlease verify that you typed the alias correctly\nAlso, be aware that the alias name cannot contain space(s). However, it can contain \"-\" (hyphen) or \"_\" (underscore)"
+		if mv -f ~/.bashrc-bck_${name}-add-"${alias_name}"-"$(date +"%d-%m-%Y")" ~/.bashrc; then
+			echo "Backup of the .bashrc file restored"
+		else
+			echo -e >&2 "\nERROR: An error occurred when restoring the backup of the ~/.bashrc file\nPlease, check for potential errors in it"
+			exit 3
+		fi
+		exit 4
 	fi
 }
 
@@ -150,23 +161,34 @@ delete() {
 			;;
 			*)
 				echo -e >&2 "\nAborting"
-				exit 1
+				exit 2
 			;;
 		esac
 
-		cp -p ~/.bashrc ~/.bashrc-bck_${name}-delete-"${alias_name}"-"$(date +"%d-%m-%Y")" && echo -e "\nBackup of the .bashrc file created" || exit 1
-		sed -i "/^alias ${alias_delete}$/d" ~/.bashrc || exit 1
+		if cp -p ~/.bashrc ~/.bashrc-bck_${name}-delete-"${alias_name}"-"$(date +"%d-%m-%Y")"; then
+			echo -e "\nBackup of the .bashrc file created"
+		else
+			echo -e >&2 "ERROR: An error occured when creating the backup of the .bashrc file"
+			exit 3
+		fi
+
+		sed -i "/^alias ${alias_delete}$/d" ~/.bashrc
 
 		source_error=$(bash -x ~/.bashrc 2>/dev/null; echo $?)
 
 		if [ "${source_error}" = 0 ]; then
-			echo -e "\nAlias ${alias_delete} successfully deleted" || exit 1
+			echo -e "\nAlias ${alias_delete} successfully deleted"
 			rm -f ~/.bashrc-bck_${name}-delete-"${alias_name}"-"$(date +"%d-%m-%Y")" && echo "Backup of the .bashrc file deleted"
 			exec bash
 		else
 			echo -e >&2 "\nERROR: An error occured when deleting the alias"
-			mv -f ~/.bashrc-bck_${name}-delete-"${alias_name}"-"$(date +"%d-%m-%Y")" ~/.bashrc && echo "Backup of the .bashrc file restored" || echo -e >&2 "ERROR: A error occurred when restoring the backup of the ~/.bashrc file\nPlease, check for potential errors in it"
-			exit 1
+			if mv -f ~/.bashrc-bck_${name}-delete-"${alias_name}"-"$(date +"%d-%m-%Y")" ~/.bashrc; then
+				echo "Backup of the .bashrc file restored"
+			else
+				echo -e >&2 "\nERROR: An error occurred when restoring the backup of the ~/.bashrc file\nPlease, check for potential errors in it"
+				exit 3
+			fi
+			exit 4
 		fi
 	else
 		echo -e >&2 "\nError : Invalid input\nPlease, make sure you typed the correct number associated to the alias you want to delete"