Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mpris): Implement MPRIS compatability layer with Root and Player interfaces supported #241

Merged
merged 9 commits into from
Feb 14, 2025

Conversation

AnthonyMichaelTDM
Copy link
Owner

@AnthonyMichaelTDM AnthonyMichaelTDM commented Feb 14, 2025

fixes #229
fixes #228

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 86.77686% with 48 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
mpris/src/interfaces/player.rs 88.01% 26 Missing ⚠️
mpris/src/lib.rs 82.50% 14 Missing ⚠️
mpris/src/interfaces/root.rs 87.50% 4 Missing ⚠️
storage/src/test_utils.rs 86.20% 4 Missing ⚠️
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   86.32%   86.27%   -0.05%     
==========================================
  Files         102      106       +4     
  Lines        7516     7883     +367     
==========================================
+ Hits         6488     6801     +313     
- Misses       1028     1082      +54     
Components Coverage Δ
MECOMP Core 88.77% <100.00%> (+1.27%) ⬆️
MECOMP Daemon 81.91% <ø> (-0.24%) ⬇️
MECOMP Storage 90.62% <86.20%> (-0.11%) ⬇️
SurrealQLX 85.14% <ø> (ø)
OneOrMany 99.35% <ø> (ø)
Analysis 81.87% <ø> (-0.17%) ⬇️
MECOMP CLI 77.94% <ø> (ø)
MECOMP TUI 87.62% <ø> (-0.30%) ⬇️
MECOMP MPRIS 86.62% <86.62%> (∅)
Files with missing lines Coverage Δ
core/src/audio/mod.rs 93.33% <100.00%> (+2.48%) ⬆️
core/src/lib.rs 74.07% <ø> (ø)
core/src/state/mod.rs 97.82% <100.00%> (+0.20%) ⬆️
daemon/src/dynamic_updates.rs 81.81% <ø> (ø)
daemon/src/lib.rs 75.00% <ø> (ø)
tui/src/ui/app.rs 94.59% <ø> (-0.05%) ⬇️
tui/src/ui/components/control_panel.rs 58.06% <ø> (-5.81%) ⬇️
tui/src/ui/mod.rs 0.00% <ø> (ø)
mpris/src/interfaces/root.rs 87.50% <87.50%> (ø)
storage/src/test_utils.rs 92.48% <86.20%> (-1.75%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes

@AnthonyMichaelTDM AnthonyMichaelTDM merged commit e324181 into main Feb 14, 2025
21 of 26 checks passed
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the mrpis-translation-layer branch February 14, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant