Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): implement query builder for dynamic playlists #225

Merged

Conversation

AnthonyMichaelTDM
Copy link
Owner

@AnthonyMichaelTDM AnthonyMichaelTDM commented Jan 29, 2025

closes #216

@AnthonyMichaelTDM AnthonyMichaelTDM linked an issue Jan 29, 2025 that may be closed by this pull request
@AnthonyMichaelTDM
Copy link
Owner Author

technically, we have a query builder now, but I'd like it to be more like the query builders that research databases have

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 53 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tui/src/ui/widgets/popups/dynamic.rs 83.33% 17 Missing ⚠️
storage/src/db/schemas/dynamic/query.rs 88.50% 10 Missing ⚠️
tui/src/ui/widgets/popups/playlist.rs 80.43% 9 Missing ⚠️
...ui/src/ui/components/content_view/views/dynamic.rs 97.98% 6 Missing ⚠️
...i/src/ui/components/content_view/views/playlist.rs 0.00% 4 Missing ⚠️
tui/src/ui/widgets/input_box.rs 42.85% 4 Missing ⚠️
tui/src/ui/components/content_view/views/mod.rs 71.42% 2 Missing ⚠️
tui/src/ui/components/content_view/views/search.rs 85.71% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   85.90%   86.38%   +0.47%     
==========================================
  Files         100      102       +2     
  Lines        6946     7445     +499     
==========================================
+ Hits         5967     6431     +464     
- Misses        979     1014      +35     
Components Coverage Δ
MECOMP Core 88.28% <ø> (ø)
MECOMP Daemon 82.03% <ø> (+0.11%) ⬆️
MECOMP Storage 90.73% <88.76%> (-0.27%) ⬇️
SurrealQLX 85.14% <ø> (ø)
OneOrMany 99.35% <ø> (ø)
Analysis 81.87% <ø> (ø)
MECOMP CLI 77.94% <100.00%> (ø)
MECOMP TUI 88.00% <91.27%> (+0.95%) ⬆️
Files with missing lines Coverage Δ
cli/src/handlers/implementations.rs 77.00% <ø> (ø)
cli/src/handlers/printing.rs 89.13% <100.00%> (ø)
storage/src/db/schemas/dynamic/mod.rs 92.30% <100.00%> (ø)
storage/src/db/schemas/mod.rs 93.87% <100.00%> (+0.12%) ⬆️
tui/src/state/library.rs 0.00% <ø> (ø)
tui/src/state/popup.rs 0.00% <ø> (ø)
tui/src/ui/components/content_view/mod.rs 89.68% <100.00%> (+0.98%) ⬆️
...src/ui/components/content_view/views/collection.rs 95.56% <ø> (ø)
.../src/ui/components/content_view/views/sort_mode.rs 97.26% <100.00%> (-0.50%) ⬇️
tui/src/ui/components/sidebar.rs 92.23% <100.00%> (+0.23%) ⬆️
... and 10 more

... and 1 file with indirect coverage changes

@AnthonyMichaelTDM AnthonyMichaelTDM marked this pull request as ready for review February 10, 2025 08:38
@AnthonyMichaelTDM AnthonyMichaelTDM merged commit f93ef6b into main Feb 10, 2025
23 of 24 checks passed
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the 216-feattui-implement-query-builder-for-dynamic-playlists branch February 10, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(tui): implement query builder for dynamic playlists
1 participant