Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve endpoint test coverage and correct config deserialization issue #198

Merged
merged 6 commits into from
Jan 11, 2025

Conversation

AnthonyMichaelTDM
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
daemon/src/services/library.rs 67.64% 11 Missing ⚠️
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   85.18%   86.85%   +1.66%     
==========================================
  Files          93       93              
  Lines        6266     6263       -3     
==========================================
+ Hits         5338     5440     +102     
+ Misses        928      823     -105     
Components Coverage Δ
MECOMP Core 92.93% <ø> (ø)
MECOMP Daemon 81.92% <70.27%> (+12.65%) ⬆️
MECOMP Storage 90.79% <ø> (+0.10%) ⬆️
SurrealQLX 85.14% <ø> (ø)
OneOrMany 99.35% <ø> (ø)
Analysis 81.87% <ø> (ø)
MECOMP CLI 86.38% <ø> (+0.56%) ⬆️
MECOMP TUI 86.54% <ø> (ø)
Files with missing lines Coverage Δ
daemon/src/config.rs 91.89% <100.00%> (+50.71%) ⬆️
daemon/src/controller.rs 83.06% <ø> (+16.24%) ⬆️
daemon/src/lib.rs 72.72% <ø> (ø)
daemon/src/services/library.rs 76.19% <67.64%> (+6.65%) ⬆️

... and 2 files with indirect coverage changes

… tests

tests to ensure configurations are deserialized properly, and some changes to fix some issues that existed with that functionality
@AnthonyMichaelTDM AnthonyMichaelTDM merged commit 66e5798 into main Jan 11, 2025
23 of 24 checks passed
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the daemon-tests branch January 11, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant