[1.0.3] Optimize handling of invalid vote message #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Oct 9, 2024
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -4025,19 +4025,25 @@ namespace eosio { | |||
| case vote_result_t::invalid_signature: | |||
| case vote_result_t::max_exceeded: // close peer immediately | |||
| fc_elog(vote_logger, "Exceeded max votes per connection for ${c}", ("c", connection_id)); | |||
There was a problem hiding this comment.
Not from your PR. But this logging only lists Exceeded max votes as the failure reason. It can be unknown_public_key or invalid_signature
linh2931
approved these changes
Oct 9, 2024
greg7mdp
approved these changes
Oct 9, 2024
| fc_elog(vote_logger, "Exceeded max votes per connection for ${c}", ("c", connection_id)); | ||
| my_impl->connections.for_each_connection([connection_id](const connection_ptr& c) { | ||
| fc_elog(vote_logger, "Invalid vote(s), closing connection - ${c}", ("c", connection_id)); | ||
| my_impl->connections.any_of_connections([connection_id](const connection_ptr& c) { |
There was a problem hiding this comment.
Maybe define a new API in connections_manager:
template <typename F>
void for_connection(uint32_t connection_id, F&& f) {
any_of_connections([connection_id, f = std::forward<F>(f)](const connection_ptr& c) {
if (c->connection_id == connection_id) {
f();
return true;
}
return false;
});
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization of handling of errors for vote messages. Shortcut out of loop when connection is found.
Improve error message for invalid vote message.