[1.0.2] Fix incorrect reported total time of applying a received block or produced block #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Sep 30, 2024
heifner
approved these changes
Sep 30, 2024
greg7mdp
approved these changes
Sep 30, 2024
spoonincode
reviewed
Sep 30, 2024
|
|
||
| ilog("Produced block ${id}... #${n} @ ${t} signed by ${p} " | ||
| "[trxs: ${count}, lib: ${lib}${confs}, net: ${net}, cpu: ${cpu}, elapsed: ${et}, time: ${tt}]", | ||
| "[trxs: ${count}, lib: ${lib}${confs}, net: ${net}, cpu: ${cpu}, elapsed: ${et} us, time: ${tt} us]", |
There was a problem hiding this comment.
Any reason to only add us to "elapsed" and "time" but not "cpu"?
There was a problem hiding this comment.
Thanks for spotting this. There was no reason. I overlooked cpu. Will add us in a future PR.
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported fix from
mainfor incorrect reported total time of applying a received block or produced block.Only minimum required changes were made, except adding time unit
usforelapsedandtimefor better clarity becauselatencyalready hadmsas postfix.Before the change:
info 2024-09-30T14:33:33.415 nodeos controller.cpp:3633 log_applied ] Received block bcd746757a3db674... #366563000 @ 2024-08-04T19:14:51.500 signed by eosusacartel [trxs: 0, lib: 366562668, net: 0, cpu: 100, elapsed: 259, time: 869, latency: 4907921915 msAfter the change:
info 2024-09-30T14:35:11.723 nodeos controller.cpp:3627 log_applied ] Received block bcd746757a3db674... #366563000 @ 2024-08-04T19:14:51.500 signed by eosusacartel [trxs: 0, lib: 366562668, net: 0, cpu: 100, elapsed: 258 us, time: 554 us, latency: 4908020223 ms]Resolves #828