[1.0.2] Prevent sync ahead in irreversible mode #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc too far ahead. Also increase number of blocks produced at start so that nodes are in lib catchup during sync. Verify all nodes are able to sync without a block log.
…uate correctly.
greg7mdp
reviewed
Sep 24, 2024
greg7mdp
approved these changes
Sep 24, 2024
linh2931
reviewed
Sep 24, 2024
| @@ -687,6 +687,27 @@ def findInLog(self, searchStr): | |||
| return True | |||
| return False | |||
|
|
|||
| def linesInLog(self, searchStr): | |||
There was a problem hiding this comment.
Like those two common functions are defined here.
linh2931
approved these changes
Sep 24, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #789 was to create a test that verifies #777. The new test exposed an issue with the current implementation that would allow it to sync ahead too far when blocks have not made it to the fork database yet. Includes a fix that verifies fork database has the block being evaluated before considering syncing ahead.
Failing test before fix: https://github.com/AntelopeIO/spring/actions/runs/11002592099
Resolves #789