Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.2 -> main] P2P: Allow irreversible mode syncing to continue when LIB is paused #805

Merged
merged 17 commits into from
Sep 19, 2024
Merged

[1.0.2 -> main] P2P: Allow irreversible mode syncing to continue when LIB is paused #805

merged 17 commits into from
Sep 19, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 19, 2024

  • Allow a node to continue syncing ahead when LIB is paused. This is important when running in irreversible mode as the chain_head does not advance until LIB advances.
  • Added some additional debug logging to net_plugin. Also added an info level log when it allows a node to sync ahead past sync-fetch-span of head because LIB is paused.
  • Add new test cases for startup-catchup test.
    • Sync with a sync-fetch-span of 1 while in irreversible mode.
      • Note this only tripped the issue in Savanna mode as the test doesn't run long enough to trigger a LIB catchup in legacy mode. It does a HEAD catchup in legacy mode (at least in my local testing). I didn't modify the test to produce more blocks to force a LIB catchup in legacy mode as the test does already trigger LIB catchup in Savanna mode.

Tested syncing Kylin past the large LIB pause.

Merges release/1.0 into main including #777

Resolves #773

@heifner
GH-773 Add test cases for irreversible mode where sync-fetch-span les…
a60227f 
…s than head-LIB
@heifner
GH-773 Allow irreversible mode to keep syncing if LIB not moving
88a1626
@heifner
GH-773 Log when syncing ahead even though LIB is not advancing
d9a224b
@heifner
GH-773 Reword confusing sync timeout log messages
bc0bc8a
@heifner
GH-773 Make it obvious that controller.get_read_mode() is thread-safe.
4bceee0
@heifner
GH-773 Only check lib not moving in irreversible mode since non-irrev…
e82613a 
…ersible mode the chain_head will still be moving and not cause net_plugin to stop syncing.

Only consider if LIB not moving when the span is greater than sync_fetch_span. Otherwise normal operation will cause net_plugin to sync ahead when fork db is just up to date.
@heifner
GH-773 Fix should_sync_from being way to picky. It would not allow a …
1d2ceb1 
…sync when the peer reported even slightly less than sync_known_lib_num which is a very normal condition. For example sync_known_lib_num: 373330666, while peer_fhead: 373330647 when trying to sync block 129728.
@heifner
GH-773 Add additional debug logging
8737c4e
@heifner
GH-773 Guard against underflow
9a72b28
@heifner
GH-773 Add assert
cb66a69
@heifner
GH-773 Update assert to allow for block 2
2cd0188
@heifner
GH-773 Remove unneeded check
1d5d977
@heifner
GH-773 Refactor to make conditions clearer
655d0ab
@heifner
Merge branch 'release/1.0' into GH-773-sync-stuck
bdde4d8
@heifner
GH-773 Simplify logic
8a2fcf3
@heifner
Merge pull request #777 from AntelopeIO/GH-773-sync-stuck
07e3e79 
[1.0.2] P2P: Allow irreversible mode syncing to continue when LIB is paused
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-773-sync-st…
fb2d31b 
…uck-main
@heifner heifner added the OCI Work exclusive to OCI team label Sep 19, 2024
@heifner heifner linked an issue Sep 19, 2024 that may be closed by this pull request
Kylin sync stuck #773
Closed
Base automatically changed from gh_751_main to main September 19, 2024 13:53
@heifner heifner merged commit 9ed5795 into main Sep 19, 2024
36 checks passed
@heifner heifner deleted the GH-773-sync-stuck-main branch September 19, 2024 14:25
@ericpassmore
Copy link
Contributor

ericpassmore commented Sep 24, 2024 •
edited
Loading

Note:start
category: Other
component: P2P
summary: P2P: Allow irreversible mode syncing to continue when LIB is paused.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kylin sync stuck
4 participants
@heifner @ericpassmore @greg7mdp @linh2931