-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0 -> main] Harden ordered_diff; Version bump v1.0.0 final #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add size_type trait to template. Add FC_ASSERT outside of loop for source and target size range. Add back in approprate debug asserts and add some new ones. Replace invalid comment with correct one.
…hecks [1.0] Harden ordered_diff
[1.0] Bump version to v1.0.0 final
arhag
approved these changes
Sep 5, 2024
linh2931
approved these changes
Sep 5, 2024
greg7mdp
approved these changes
Sep 5, 2024
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ordered_diff
is used to process the finalizer and proposer policy diffs from block header extensionfinality_extension
. Since thefinality_extension
, is provided to a node to validate, validate the diff duringapply_diff
.Related to #691
Merges
release/1.0
intomain
including #698 & #689