[1.0] Harden ordered_diff #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a block QC extension
…r extension as it can have
greg7mdp
requested changes
Sep 4, 2024
greg7mdp
requested changes
Sep 4, 2024
| result.insert_indexes.emplace_back(t, target[t]); | ||
| FC_ASSERT(result.insert_indexes.size() <= MAX_NUM_ARRAY_ELEMENTS); |
There was a problem hiding this comment.
Issue is that we insert before the FC_ASSERT. So the FC_ASSERT can be fine because result.insert_indexes.size() == MAX_NUM_ARRAY_ELEMENTS, and the next emplace_back will go over.
=> change the FC_ASSERT to < and move before the emplace_back.
This applies to the other locations as well.
greg7mdp
reviewed
Sep 4, 2024
| container.insert(container.begin() + index, std::move(value)); | ||
| FC_ASSERT(container.size() <= MAX_NUM_ARRAY_ELEMENTS); |
There was a problem hiding this comment.
same here, change to < and move before line 118.
greg7mdp
reviewed
Sep 4, 2024
Comment on lines
45
to
46
| FC_ASSERT(s < std::numeric_limits<SizeType>::max()); | ||
| FC_ASSERT(t < std::numeric_limits<SizeType>::max()); |
There was a problem hiding this comment.
Please move these two before the if, otherwise we skip the increments at line 84 and 89.
|
Replaced by #698 which targets updated branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ordered_diffis used to process the finalizer and proposer policy diffs from block header extensionfinality_extension. Since thefinality_extension, is provided to a node to validate, validate the diff duringapply_diff.Related to #691