[1.0 -> main] Use other_branch_latest_time for liveness #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol votes_forked_since_latest_strong_vote for vote decision
[1.0] Use other_branch_latest_time for liveness
greg7mdp
approved these changes
Aug 27, 2024
linh2931
approved these changes
Aug 27, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
other_branch_latest_timeblock timestamp instead of a booleanvotes_forked_since_latest_strong_votefor tracking votes on other fork branches. See #621 for complete details.Fixes currently failing test on #619.
Merges
release/1.0intomainincluding #627Resolves #621 (Tests coming in separate PR #636)