Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with fsi handling and block_ref creation. #537

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Fix issue with fsi handling and block_ref creation. #537

merged 10 commits into from
Aug 14, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Aug 14, 2024 •
edited
Loading

Resolves #534

  1. consistently initialize block_ref with the finality_digest.
  2. update voting rule 2 (determines whether to vote strong vs weak)) and update fsi and file format.
  3. update tests.

@greg7mdp greg7mdp marked this pull request as draft August 14, 2024 14:34
@greg7mdp greg7mdp marked this pull request as ready for review August 14, 2024 16:32
@greg7mdp greg7mdp requested review from linh2931, heifner and arhag August 14, 2024 16:32
heifner
heifner requested changes Aug 14, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/finality/finalizer.cpp Outdated Show resolved Hide resolved
libraries/chain/include/eosio/chain/finality/finality_core.hpp Show resolved Hide resolved
arhag
arhag reviewed Aug 14, 2024
View reviewed changes
libraries/chain/include/eosio/chain/block_header_state.hpp Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/finality/finalizer.cpp Outdated Show resolved Hide resolved
unittests/finalizer_tests.cpp Outdated Show resolved Hide resolved
@greg7mdp greg7mdp mentioned this pull request Aug 14, 2024
Closed
@greg7mdp greg7mdp merged commit 8afe904 into main Aug 14, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_534 branch August 14, 2024 19:53
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Improve Finality Safety Information, consistently initializing block_ref, and ensuring weak votes aren't masked.
Note:end

greg7mdp added a commit that referenced this pull request Aug 23, 2024
@greg7mdp
Add test demonstrating the weak masking issue on commit 7beaa20 prior…
be71b28 
… to PR #537 implementing the FSI changes to avoid the issue.
This was referenced Aug 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@arhag arhag arhag approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in how fsi is handled
5 participants
@greg7mdp @ericpassmore @heifner @arhag @linh2931