Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta4 -> main] Log when block has no QCs #449

Merged
merged 6 commits into from
Jul 31, 2024
Merged

[1.0-beta4 -> main] Log when block has no QCs #449

merged 6 commits into from
Jul 31, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 30, 2024

Helpful to distinguish between only missing one vote or no votes making into a block.
Add log of all recevied blocks with qc claim, previous, and timestamp.

Merges release/1.0-beta4 into main including #434

@heifner heifner requested review from greg7mdp and linh2931 July 30, 2024 20:35
@heifner heifner added the OCI Work exclusive to OCI team label Jul 30, 2024
@heifner heifner merged commit 496262a into main Jul 31, 2024
36 checks passed
@heifner heifner deleted the log-main branch July 31, 2024 01:20
@ericpassmore
Copy link
Contributor

Note:start
group: LOGGING
category: INTERNALS
summary: Add logging when block has no QCs.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants