multi threaded snapshot loading #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Jul 30, 2024
| authorization.read_from_snapshot(snapshot, rows_loaded, snapshot_load_ctx); | ||
| resource_limits.read_from_snapshot(snapshot, rows_loaded, snapshot_load_ctx); | ||
|
|
||
| constexpr unsigned max_snapshot_load_threads = 4; |
There was a problem hiding this comment.
There is diminishing returns beyond this. Really even 2 or 3 is probably similar performance to 4 with current EOS data set.
spoonincode
commented
Jul 30, 2024
libraries/chain/controller.cpp
Outdated
|
|
||
| std::vector<std::promise<void>> thread_promises(snapshot_load_threads); | ||
| std::list<std::thread> threads; | ||
| //this scoped_exit can go away with jthread; but still marked experimental in libc++18 |
There was a problem hiding this comment.
I guess I goofed this up before making #400. I thought I tested locally with libc++18 I could use jthread but clearly that isn't the case.
|
Note:start |
heifner
requested changes
Jul 31, 2024
heifner
approved these changes
Aug 8, 2024
these stored snapshots are used for future test_compatible_versions runs
greg7mdp
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi threaded snapshot loading.
Different environments will have different performance uplifts, but in my environment with a recent EOS snapshot, loading time decreased from 90 seconds to 60 seconds.
This implements a very simple parallelization scheme where each snapshot section (which roughly corresponds to each chainbase table) is loaded in parallel. To get better parallelization we will need to load a single chainbase table in parallel since the contract table far outweighs the other tables. That is certainly doable, but far more complex.
Resolves #437