change experimental-binaries to antelope-spring-experimental-binaries to avoid version overlap with leap packages
#288
Conversation
.github/workflows/release.yaml
Outdated
| @@ -49,5 +49,5 @@ jobs: | |||
| uses: docker/build-push-action@v3 | |||
| with: | |||
| push: true | |||
| tags: ghcr.io/${{env.REPOSITORY_OWNER_LOWER}}/experimental-binaries:${{github.ref_name}} | |||
| tags: ghcr.io/${{env.REPOSITORY_OWNER_LOWER}}/spring-experimental-binaries:${{github.ref_name}} | |||
There was a problem hiding this comment.
Should this be antelope-spring-experimental-binaries to match antelope-spring name?
There was a problem hiding this comment.
I could go either way on this.. antelope-spring matches the names of the packages that are placed in here, but spring is the name of the repo.
I think maybe since we'll use this string along with other strings that are antelope-spring (the package name and the artifact name),
https://github.com/AntelopeIO/cdt/blob/9ecdca0f080b65e1339318cd2451a5f2593c4ee5/.github/workflows/build.yaml#L111-L115
it probably does make sense to make it antelope-spring just to keep everything looking similar in that block above. I'll update in a moment.
experimental-binaries to spring-experimental-binaries to avoid version overlap with leap packagesexperimental-binaries to antelope-spring-experimental-binaries to avoid version overlap with leap packages
|
Note:start |
Since we're going to have to change downstream users of the dev package anyways due to #287, might as well make this change now too so we can resolve #50