Test: Add integration test of setfinalizers after transition #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
May 23, 2024
| @@ -124,7 +124,8 @@ const proposer_policy& block_header_state::get_last_proposed_proposer_policy() c | |||
| void finish_next(const block_header_state& prev, | |||
| block_header_state& next_header_state, | |||
| vector<digest_type> new_protocol_feature_activations, | |||
| instant_finality_extension if_ext) { | |||
| instant_finality_extension if_ext, | |||
| bool log) { // only log on assembled blocks, to avoid double logging | |||
There was a problem hiding this comment.
It would be nicer if we could move the logging out of this method to the caller, without adding this parameter just for logging. But detailed information we want to log is not accessible in the caller.
spoonincode
approved these changes
May 23, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setfinalizerafter transition to Savanna