Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.4 -> main] Fix stuck plugin_http_api_test #1008

Merged
merged 5 commits into from
Nov 2, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Nov 1, 2024

Forwards #1007

plugin_http_api_test gets stuck sometimes. This is caused by producer API related tests, where after pause and resume tests, update_runtime_options test modifies max_irreversible_block_age to 1 second which causes producer plugin to be stuck in speculative mode.

The PR

  • restores options modified by update_runtime_options test to default values afterwards
  • in addition to fixing the stuck problem, removes max_scheduled_transaction_time_per_block_ms and incoming_defer_ratio from update_runtime_options test as those options were already removed in Leap 5.0.

Resolves #992

Detailed log showing the problem:

info  2024-10-30T14:16:59.920 nodeos    producer_plugin.cpp:1650      pause                ] Producer paused.
info  2024-10-30T14:16:59.921 nodeos    producer_plugin.cpp:1650      pause                ] Producer paused.
info  2024-10-30T14:16:59.923 nodeos    producer_plugin.cpp:1168      resume               ] Producer resumed.
info  2024-10-30T14:16:59.923 nodeos    producer_plugin.cpp:1168      resume               ] Producer resumed.
error 2024-10-30T14:17:00.004 nodeos    producer_plugin.cpp:2038      start_block          ] Not producing block because the         irreversible block is too old [age:1s, max:1s], block 2024-10-30T14:17:00.500

@linh2931 linh2931 requested review from heifner and greg7mdp November 1, 2024 22:02
@linh2931 linh2931 merged commit d94e588 into main Nov 2, 2024
36 checks passed
@linh2931 linh2931 deleted the merge_fix_plugin_http_api_test branch November 2, 2024 14:31
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: P2P
summary: Fix stuck plugin http test.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: plugin_http_api_test
4 participants