Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max-reversible-blocks should only prevent block production #641

Closed
arhag opened this issue Aug 26, 2024 · 0 comments · Fixed by #652 or #656
Closed

max-reversible-blocks should only prevent block production #641

arhag opened this issue Aug 26, 2024 · 0 comments · Fixed by #652 or #656
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.0-rc3

Comments

@arhag
Copy link
Member

arhag commented Aug 26, 2024

Nodeos should no longer shut down if the number of blocks in the fork database exceeds the configured max-reversible-blocks.

Instead, when producer plugin is about to produce a block, it should check to the block_header_state finality_core for the number of reversible blocks in that branch. If that exceeds max-reversible-blocks, then it should avoid producing the block (can just be speculating) and log a warning message.
@arhag arhag added this to the Spring v1.0.0-rc3 milestone Aug 26, 2024
@arhag arhag removed the triage label Aug 26, 2024
@heifner heifner self-assigned this Aug 27, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 27, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 27, 2024
@heifner heifner mentioned this issue Aug 27, 2024
Closed
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
GH-641 Remove max-reversible-blocks shutdown option. With this commit…
e679265 
…, max-reversible-blocks does nothing.
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
GH-641 Move max-reversible-blocks to producer_plugin since it only af…
45162f2 
…fects block production now.
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
GH-641 Pause production when max-reversible-blocks is reached.
15ae10f
@heifner heifner mentioned this issue Aug 27, 2024
Merged
@heifner heifner linked a pull request Aug 27, 2024 that will close this issue
[1.0] Pause production when max-reversible-blocks reached #652
Merged
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
GH-641 Check max-reversible-blocks is not zero
03c79ec
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
Merge pull request #652 from AntelopeIO/GH-641-max-reversible-blocks-…
511eabe 
…block-production

[1.0] Pause production when max-reversible-blocks reached
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-641-max-rev…
fdb4e46 
…ersible-blocks-block-production-main
@heifner heifner mentioned this issue Aug 27, 2024
Merged
@heifner heifner linked a pull request Aug 27, 2024 that will close this issue
[1.0 -> main] Pause production when max-reversible-blocks reached #656
Merged
heifner added a commit that referenced this issue Aug 27, 2024
@heifner
Merge pull request #656 from AntelopeIO/GH-641-max-reversible-blocks-…
c8cd61a 
…block-production-main

[1.0 -> main] Pause production when max-reversible-blocks reached
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.0-rc3
4 participants
@heifner @arhag @enf-ci-bot and others