Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not timeout P2P connections when creating a snapshot #592

Closed
heifner opened this issue Aug 19, 2024 · 1 comment · Fixed by #768 or #784
Closed

Do not timeout P2P connections when creating a snapshot #592

heifner opened this issue Aug 19, 2024 · 1 comment · Fixed by #768 or #784
Assignees
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone

Comments

@heifner
Copy link
Member

heifner commented Aug 19, 2024

Creating a snapshot ties up the main thread for the time it takes to create the snapshot. During that time, new blocks can't be processed by the main thread. This can cause the net_plugin's sync timer and/or block timer to fire and disconnect from its peers. The connection timer then has to fire for the connections to be re-established. This can cause a node that is syncing and periodically creating snapshots to pause after each snapshot waiting for connections to be re-established and syncing to continue.

@bhazzard
Copy link

bhazzard commented Sep 5, 2024

Possible solution may entail: Block timers during syncing should only be active when there is a pending request for blocks.

@bhazzard bhazzard added 👍 lgtm and removed triage labels Sep 5, 2024
@bhazzard bhazzard added this to the Spring v1.0.1 milestone Sep 5, 2024
@bhazzard bhazzard added the bug The product is not working as was intended. label Sep 5, 2024
@arhag arhag modified the milestones: Spring v1.0.1, Spring v1.0.2 Sep 6, 2024
@heifner heifner self-assigned this Sep 10, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Sep 10, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Sep 10, 2024
heifner added a commit that referenced this issue Sep 12, 2024
@heifner heifner linked a pull request Sep 12, 2024 that will close this issue
heifner added a commit that referenced this issue Sep 16, 2024
[1.0.2] Remove explicit net_plugin pause during snapshot
heifner added a commit that referenced this issue Sep 16, 2024
heifner added a commit that referenced this issue Sep 16, 2024
…main

[1.0.2 -> main] Remove explicit net_plugin pause during snapshot
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
4 participants