-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not timeout P2P connections when creating a snapshot #592
Milestone
Comments
Possible solution may entail: Block timers during syncing should only be active when there is a pending request for blocks. |
This was referenced Sep 12, 2024
heifner
added a commit
that referenced
this issue
Sep 16, 2024
[1.0.2] Remove explicit net_plugin pause during snapshot
heifner
added a commit
that referenced
this issue
Sep 16, 2024
…main [1.0.2 -> main] Remove explicit net_plugin pause during snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Creating a snapshot ties up the main thread for the time it takes to create the snapshot. During that time, new blocks can't be processed by the main thread. This can cause the net_plugin's sync timer and/or block timer to fire and disconnect from its peers. The connection timer then has to fire for the connections to be re-established. This can cause a node that is syncing and periodically creating snapshots to pause after each snapshot waiting for connections to be re-established and syncing to continue.
The text was updated successfully, but these errors were encountered: