-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2P: Limit requested blocks to avoid max-reversible-blocks #528
Comments
heifner
added a commit
that referenced
this issue
Aug 14, 2024
heifner
added a commit
that referenced
this issue
Aug 15, 2024
heifner
added a commit
that referenced
this issue
Aug 15, 2024
heifner
added a commit
that referenced
this issue
Aug 15, 2024
heifner
added a commit
that referenced
this issue
Aug 16, 2024
heifner
added a commit
that referenced
this issue
Aug 16, 2024
heifner
added a commit
that referenced
this issue
Aug 16, 2024
heifner
added a commit
that referenced
this issue
Aug 17, 2024
heifner
added a commit
that referenced
this issue
Aug 18, 2024
[1.0] Limit sync-fetch-span by max-reversible-blocks if needed
heifner
added a commit
that referenced
this issue
Aug 18, 2024
spoonincode
added a commit
that referenced
this issue
Aug 19, 2024
heifner
added a commit
that referenced
this issue
Aug 19, 2024
[1.0 -> main] Limit sync-fetch-span by max-reversible-blocks if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
sync-fetch-span
provides an upper limit on how many blocks ahead of applied blocks (chain_head
) are allowed to be requested. As it is today, the maximum allowed number of unapplied blocks that can be requested/received is2 * sync-fetch-span - 1
. A largesync-fetch-span
or a smallmax-reversible-blocks
option can cause a node to shutdown if the accumulated reversible blocks exceeds themax-reversible-blocks
.Limit
net_plugin
requested blocks to the minimum ofmax-reversible-blocks - forkdb.size()
andsync-fetch-span
to avoid hitting themax-reversible-blocks
during P2P syncing.max-reversible-blocks
PR is #493The text was updated successfully, but these errors were encountered: