Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P: Limit requested blocks to avoid max-reversible-blocks #528

Closed
heifner opened this issue Aug 13, 2024 · 0 comments · Fixed by #545 or #576
Closed

P2P: Limit requested blocks to avoid max-reversible-blocks #528

heifner opened this issue Aug 13, 2024 · 0 comments · Fixed by #545 or #576
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Aug 13, 2024

Currently, sync-fetch-span provides an upper limit on how many blocks ahead of applied blocks (chain_head) are allowed to be requested. As it is today, the maximum allowed number of unapplied blocks that can be requested/received is 2 * sync-fetch-span - 1. A large sync-fetch-span or a small max-reversible-blocks option can cause a node to shutdown if the accumulated reversible blocks exceeds the max-reversible-blocks.

Limit net_plugin requested blocks to the minimum of max-reversible-blocks - forkdb.size() and sync-fetch-span to avoid hitting the max-reversible-blocks during P2P syncing.

max-reversible-blocks PR is #493

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 13, 2024
@heifner heifner changed the title P2P: Limit requested blocks to avoid max-reversible-blocks sync-fetch-span P2P: Limit requested blocks to avoid max-reversible-blocks Aug 13, 2024
@arhag arhag added 👍 lgtm and removed triage labels Aug 13, 2024
@arhag arhag added this to the Spring v1.0.0-rc2 milestone Aug 13, 2024
@heifner heifner self-assigned this Aug 14, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 14, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 14, 2024
heifner added a commit that referenced this issue Aug 16, 2024
heifner added a commit that referenced this issue Aug 18, 2024
[1.0] Limit sync-fetch-span by max-reversible-blocks if needed
heifner added a commit that referenced this issue Aug 19, 2024
[1.0 -> main] Limit sync-fetch-span by max-reversible-blocks if needed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment