-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Add setfinalizer action to eosio.bios #33
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
37e4b25
add setfinalizer to eosio.bios
linh2931 6eac8c2
add tests for eosio.bios setfinalizer action
linh2931 7181593
add more comments to eosio.bios setfinalizer tests
linh2931 0d5cc0d
update Leap and CDT versions for CICD
linh2931 f91b47f
use std::move for argument passing
linh2931 4e31832
correct a typo of privileged
linh2931 37c4dc3
update CDT asset-artifact-download-action from v2 to v3
linh2931 da83307
add apt-get update && apt-get upgrade -y before apt install
linh2931 d9dceab
change leap-dev asset-artifact-download-action to v3
linh2931 5b3c58e
remove token usage
linh2931 d7f7616
correct comments about setfinalizer and add max_finalizers and max_fi…
linh2931 312f46a
add checks for duplicate keys, too small threshold, weight sum overfl…
linh2931 d5bf241
add additional tests for setfinalizer input validation
linh2931 8676a92
simplify building long description in tests and add a test for descri…
linh2931 ac597ea
use affine raw format for key uniqueness check
linh2931 89672ac
move g1_hash and g1_equal inside function body and next to their use,…
linh2931 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
{ | ||
"leap-dev":{ | ||
"target":"3", | ||
"target":"hotstuff_integration", | ||
"prerelease":false | ||
}, | ||
"cdt":{ | ||
"target":"3", | ||
"target":"hotstuff_integration", | ||
"prerelease":false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also change the download below to
v3
,reference-contracts/.github/workflows/build.yaml
Lines 74 to 75 in da83307
Also, v3 does not require the
token
in our usage, so you can remove linesreference-contracts/.github/workflows/build.yaml
Line 73 in da83307
reference-contracts/.github/workflows/build.yaml
Line 84 in da83307