Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boost version. #990

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Update boost version. #990

merged 3 commits into from
Apr 10, 2023

Conversation

oschwaldp-oci
Copy link
Contributor

@oschwaldp-oci oschwaldp-oci commented Apr 7, 2023

Updating min Boost version to be in line with pinned_build.sh min requirement.

With dropping support for Ubuntu 18.04 and Ubuntu 20.04's min boost version of 1.71, it should be okay to bump leap's min to the pinned build's min required boost version 1.70.

@spoonincode
Copy link
Member

This is fine, are you planning to prune out unneeded boost stuff?

@heifner heifner added the OCI Work exclusive to OCI team label Apr 8, 2023
@oschwaldp-oci
Copy link
Contributor Author

oschwaldp-oci commented Apr 10, 2023

This is fine, are you planning to prune out unneeded boost stuff?

Trimmed out all of the BOOST_VERSION < 1.7 and > 1.6 checks in the main leap code here: 5ca4425 and here c5a956d

Was there more you were hoping to do?

@oschwaldp-oci oschwaldp-oci merged commit 29dd998 into main Apr 10, 2023
@oschwaldp-oci oschwaldp-oci deleted the update-leap-boost-version branch April 10, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants