[4.0 -> main] Remove global WASM::check_limits and initial memory from instantiate_module #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.0] Remove global WASM::check_limits and initial memory from instantiate_module
…heck_limits_to_main
heifner
approved these changes
Apr 5, 2023
spoonincode
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #975 to main.
#969 identified global scoped_skip_checks can be accessible by multiple read-only threads. This variable is not needed in
wasm_interface_impl::get_instantiated_module.Another finding was initial memory argument in
instantiate_modulewas not needed in all theinstantiate_modulemethods. I double checked that it was un-named in all the implementations ofinstantiate_module. Safe to remove.This PR removed both of them.