[4.0 -> main] Clean tmp and TestLogs after test runs #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.0] Clean tmp and TestLogs after test runs
heifner
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes this PR from 4.0 and puts it into main #915
`This PR cleans up a number of tests that have been littering.
unittests/snapshot_tests.cppwas leaving tmp files around even on successThese tests were all leaving logs around in TestLogs even on on success:
tests/auto_bp_peering_test.pytests/cli_test.pytests/nodeos_contrl_c_test.pytests/plugin_http_api_test.pytests/trace_plugin_test.pytest/performance_test_basic(nonbasic also as a result)unittests/restart_chain_tests.cpphad some old code that was unused, which had previously behaved similarly to temp_dir.Additionally changed
tests/TestHarness/WalletMgr.pyto clean up the test wallets after test success.Resolves: #719