Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests that are sub 3 minutes out of long running classification #84

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

spoonincode
Copy link
Member

Move tests that execute in less than 3 minutes out of the long_running_tests bucket and in to the nonparallelizable_tests bucket.

Long running tests are also moved to a new runner type, enf-x86-lowtier. This is an 8vCPU 16GB instance. Similar to NP tests, most of these long running tests idle around so I am "over subscribing" them for now. We can always bump up the resources on this runner type if needed. Like midtier, enf-x86-lowtier is running on the "give me whatever you got tier" which seems to be getting rather old Broadwell CPUs.

🚨 This completely removes nodeos_sanity_lr_test. afaict it's the exact same test as the non-lr test; am I missing something? 🚨

add_test(NAME nodeos_sanity_test COMMAND tests/nodeos_run_test.py -v --sanity-test --clean-run --dump-error-detail WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
add_test(NAME nodeos_sanity_lr_test COMMAND tests/nodeos_run_test.py -v --sanity-test --clean-run --dump-error-detail WORKING_DIRECTORY ${CMAKE_BINARY_DIR})

A manual workflow run on this branch with LR tests clutched in is at
https://github.com/AntelopeIO/leap/actions/runs/2966597472

@spoonincode spoonincode added the CICD Anything dealing with the CI workflow behavior label Aug 31, 2022
Base automatically changed from parallel_nonparallel to main August 31, 2022 23:10
@spoonincode spoonincode merged commit d3e8c4a into main Aug 31, 2022
@spoonincode spoonincode deleted the not_so_long_running branch August 31, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Anything dealing with the CI workflow behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants