[3.2] improve CICD build time via faster artifact upload & parallel leap-dev creation #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves CICD build time by about 20% (reducing the build stage from ~5m to ~4m) by two improvements:
leap-devpackage in parallel while the tests run. It's not unusual for building the packages to take 30 seconds, so kicking that task over to a slow GitHub runner to be done in parallel while tests are running saves some time.Some slight whitespace adjustments came along for the ride.
In retrospect I should have called "All Required Tests Passed" something like "All Required Jobs Passed" -- we want to make sure leap-dev builds, but it's not really a 'test'. Not willing to monkey with that any more at the moment. Then again, at some point in the future we'll want to test building contracts too after the leap-dev job.