[PH] Expose various Nodeos Options in performance_test_basic #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic. Also hardcode some others.
oschwaldp-oci
suggested changes
Feb 23, 2023
…arness_nodeos_config_options
…ted README. Use choices for wasm-runtime. Add new options to the *Args constructors in both performance tests.
oschwaldp-oci
suggested changes
Feb 27, 2023
… of bools. Put eos-vm-oc-enable in ptb only onto non producer nodes. Remove duplicate choice in wasm-runtime
oschwaldp-oci
suggested changes
Feb 28, 2023
…cting non producer nodes. Resolve related test failure.
oschwaldp-oci
approved these changes
Feb 28, 2023
…gning transactions
oschwaldp-oci
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly Exposed options:
wasm-runtimecontracts-consoleeos-vm-oc-cache-size-mbeos-vm-oc-compile-threadseos-vm-oc-enableblock-log-retain-blockshttp-threadsRemoved Options:
chain-state-db-size-mbA few hardcoded values were set in performance_test_basic using he constructors for *Args:
maxTransactionTime(max-transaction-time)chainStateDbSizeMb(chain-state-db-size-mb)abiSerializerMaxTimeMs(abi-serializer-max-time-ms)httpMaxBytesInFlightMb(http-max-bytes-in-flight-mb)httpMaxResponseTimeMs(http-max-response-time-ms)maxClients(max-clients)resourceMonitorNotShutdownOnThresholdExceeded(resource-monitor-not-shutdown-on-threshold-exceeded)Also as part of this task, a previously hardcoded part of cluster has been changed so that
max-transaction-time,abi-serializer-max-time-ms,p2p-max-nodes-per-host, andmax-clientscan be passed to nodeos via cluster without causing failures.Also adds a bugfix to resolve duplicate transaction generation when transactions are resigned