Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1 -> 3.2] Interrupt speculative start_block when a block is received #648

Merged
merged 18 commits into from
Jan 18, 2023
Merged

[3.1 -> 3.2] Interrupt speculative start_block when a block is received #648

merged 18 commits into from
Jan 18, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 18, 2023

Interrupt speculative start_block when a block is received, after the block header has been validated, so it can be immediately processed even when there is a backlog of pending transactions.

  • Forkdb made thread-safe.
  • Block header validation now done on net threads instead of producer threads when previous block already processed.

Resolves #525
Resolves #517

Merges #543 into release/3.2

heifner added 18 commits December 6, 2022 14:09
@heifner
GH-525 Interrupt speculative start_block when a block is received
0103412
@heifner
GH-525 Use received block as interrupt for start_block when in specul…
1f44c07 
…ative mode. Use deadline when in production mode.
@heifner
GH-525 Fixed spelling of yield
8027ecb
@heifner
GH-525 Minor cleanup
e63482a
@heifner
GH-525 Honor deadline if we can produce
40a7e34
@heifner
GH-525 Make forkdb thread-safe
43d45ed
@heifner
GH-525 Remove unused block channel.
7468ded
@heifner
GH-525 Move scope_exit of schedule_production_loop since any call sho…
d0d7fa7 
…uld restart block because speculative block may have been interrupted.
@heifner
GH-525 Use shared_mutex to allow multiple readers
b3391af
@heifner
GH-525 Only interrupt start_block for validated block_header.
9b1401a
@heifner
GH-525 Minor cleanup from PR comments.
8f12805
@heifner
GH-525 Add open_impl/close_impl so all methods of fork_database follo…
453e5d0 
…w the same pattern.
@heifner
GH-525 Remove unused incoming::channels::transaction
9b5ec62
@heifner
Merge branch 'release/3.1' into GH-525-block-propagation-3.1
ef9b3ea
@heifner
GH-525 Add check for existing to be consistent
3d77eb0
@heifner
GH-525 rename start_block_interrupted to should_interrupt_start_block
2d6307b
@heifner
Merge pull request #543 from AntelopeIO/GH-525-block-propagation-3.1
be7fc57 
[3.1] Interrupt speculative start_block when a block is received
@heifner
Merge remote-tracking branch 'origin/release/3.1' into GH-525-block-p…
bce4029 
…ropagation-3.2-merge
@heifner heifner requested review from linh2931 and larryk85 January 18, 2023 18:46
@heifner heifner added the OCI Work exclusive to OCI team label Jan 18, 2023
@heifner heifner merged commit 4107ba4 into release/3.2 Jan 18, 2023
@heifner heifner deleted the GH-525-block-propagation-3.2-merge branch January 18, 2023 19:59
@heifner heifner mentioned this pull request Jan 18, 2023
Merged
This was referenced Mar 24, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryk85 larryk85 larryk85 approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @larryk85 @linh2931