[PH] Support configuring transaction type to send in trx generator through JSON transaction description #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to transaction generator to take input of abi from file, transaction action type, and action data from a string or file json description and generate transactions matching that description. Rename handler_account to contract_owner_account for more accurate description. Add integration test exercising the new functionality that builds transactions from abi, action type and action data. Makes use of the performance_test_basic with new argument '--exercise-trx-specification', but generates the transfer transactions from the abi, action name and action description in the test. Added unit test to exercise the new trx_generator constructor.
heifner
requested changes
Jan 10, 2023
heifner
reviewed
Jan 10, 2023
…rxData. Update performance_test_basic to support user specified transaction data through the use of the --user-trx-data command argument and the UserTrxData class. Now supports creation of named accounts for use in user defined transactions. Cluster supports populating wallet with named accounts. Renamed command line argument for making use of user provided trx data to --user-trx-data.
Fix trx_expr to be fc::microseconds instead of int64_t
Replace prev argument --user-trx-data with --user-trx-data-file. Read user trx data in from file and use that directly in lieu of UserTrxData. Update tests to exercise this path with sample userTrxData.json file. Update report construction to support Paths.
heifner
approved these changes
Jan 12, 2023
heifner
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON Transaction Description Support
Add the ability to configure the type of transaction to generate/send from a JSON transaction description (file, str, etc.)
Added functionality to transaction generator to take input of abi from file, transaction action type, and action data from a string or file json description and generate transactions matching that description.
Transaction Generator now takes additional arguments:
action-nameThe action name applied to the provided action data inputaction-dataThe path to the json action data file or json action data description string to useabi-fileThe path to the contract abi file to use for the supplied transaction action dataTransaction Generator refactor base class
transaction_generator_basebase class.launch_transaction_generators.pyalso now supports:action_nameThe action name applied to the provided action data inputaction_dataThe path to the json action data file or json action data description string to useabi_fileThe path to the contract abi file to use for the supplied transaction action dataperformance_test_basic.pynow supports:--user-trx-data-filePath to userTrxData.jsonOther Changes/Additions:
Rename handler_account to contract_owner_account for more accurate description.
Add integration test exercising the new functionality that builds transactions from abi, action type and action data. Makes use of the performance_test_basic with new argument --user-trx-data-file' and provided example
userTrxData.json, but generates the transfer transactions from the abi, action name and action description in the test.Added support to
Cluster.pyto allow populating wallet and creating accounts with specific account names for testing purposes (in particular to use with the--user-trx-data-filewhere a user would like to have foreknowledge about account names to use in action data).