[PH] Performance harness Log Number of Forks and Forked Blocks #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Jan 5, 2023
| @@ -200,6 +202,9 @@ def scrapeLog(data, path): | |||
| data.updateTotal(int(value[2]), 0, 0, 0, 0, int(v2Logging[0])) | |||
| else: | |||
| print("Error: Unknown log format") | |||
| forks = re.findall(r'switching forks from ([0-9a-fA-F]+) \(block number (\d+)\) to ([0-9a-fA-F]+) \(block number (\d+)\)', line) | |||
| for fork in forks: | |||
| data.forkedBlocks.append(int(fork[1]) - int(fork[3])) | |||
There was a problem hiding this comment.
I think this needs a +1. Example:
info 2022-12-28T18:06:18.000 nodeos controller.cpp:2309 maybe_switch_forks ] switching forks from 000000ddca004dc9992db186880efea4908850901e21999ae0861d2dc9916402 (block number 221) to 000000dd705ab2c8b1a3d527c691ae98ad904e3b49b1f3d45ae9ae09fd22e6be (block number 221)
Also want to track # of times a fork happens separately from total fork distance.
There was a problem hiding this comment.
# of times a fork happens is done using len(data.forkedBlocks) so it doesn't need to be saved here unless I'm missing something. I'll add the +1 because what you said makes sense.
There was a problem hiding this comment.
Thanks, missed the len(data.forkedBlocks)
oschwaldp-oci
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PH now uses nodeos logs to report forks and forked blocks during performance testing.