[PH] Replace usage of os.path with Path and PurePath #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiszczak
suggested changes
Dec 14, 2022
jgiszczak
approved these changes
Dec 23, 2022
| testSuccessful = False | ||
|
|
||
| # Test log scraping for 3.2 log format | ||
| dataCurrent = log_reader.chainData() | ||
| dataCurrent.startBlock = None | ||
| dataCurrent.ceaseBlock = None | ||
| log_reader.scrapeLog(dataCurrent, "tests/performance_tests/nodeos_log_3_2.txt.gz") | ||
| log_reader.scrapeLog(dataCurrent, Path("tests")/Path("performance_tests")/Path("nodeos_log_3_2.txt.gz")) |
There was a problem hiding this comment.
The / operator supported by Path accepts strings as well as Path objects, including chains of strings, as long as the first part is a Path. I prefer to write this sort of thing as Path('tests') / 'performance_tests' / 'nodeos_log_3_2.txt.gz' since it's less verbose. This includes f-strings.
oschwaldp-oci
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces instances of os.path with corresponding Path and PurePath. str conversion is necessary for use with sys.path