[3.2] use consistent HTTP server header on both success and failure responses #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will need to be reworked going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#378 sets a more specific HTTP Host header for replies. Well, apparently it only did on successful replies because the code overwrites that header on error replies, which I missed. There appears to be no reason to set these header fields again here -- they're set when the
res_object is created.Also, forcing the connection close on an error reply here seems overkill. There is no reason that needs to happen: an error response doesn't prevent a new request from being sent on the same connection. Not touching that in 3.2 though.