Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] initialize slice_directory::index_header::version to avoid warning in tests #277

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

spoonincode
Copy link
Member

The lack of an initializer for version was leading to a use before set warning in the trace_api_plugin tests

slice_directory::index_header h;
const auto data = fc::raw::pack(h);

Our general practice is to initialize PODs in structs, so let's do that here.

@spoonincode spoonincode merged commit f4227f6 into main Oct 4, 2022
@spoonincode spoonincode deleted the init_slice_index_header branch October 4, 2022 15:35
@spoonincode spoonincode changed the title [3.2] initialize slice_directory::index_header::version [3.2] initialize slice_directory::index_header::version to avoid warning in tests Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants