[3.1 -> main] Fix replay to correctly add trxs into the de-dup list #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[3.1] Fix replay to correctly add trxs into the de-dup list
linh2931
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replaying a block log, the transactions with expirations equal to the last irreversible block time were not added to the trx de-dup list. This creates a difference in the de-dup list vs starting from state or a snapshot. Note transactions are cleared from the de-dup list at the start of a block according to if they are less than (not less than or equal) the pending block time.
Regression test will come in a different PR. See #268.
Resolves eosnetworkfoundation/mandel#301
Merges #273 to
main