[3.2] Do not log or subjective bill for duplicate trxs #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging of duplicate transactions is confusing as it looks like a transaction failure case. However, duplicate transactions are expected and do not indicate any sort of error condition. The most common cause of duplicate transaction is receiving a transaction in a block before receiving it over P2P for speculative execution. All transactions received via a block before being received by P2P are duplicate.
Also do not subjectively bill for duplicate trxs. We have never subjectively billed for duplicate transactions, but the unreleased refactor #29 mistakenly subjectively billed for some duplicate transactions.
Resolves #231