[PH] Performance harness graceful shutdown #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ClaytonCalabrese
commented
Sep 26, 2022
- Causes trx_generators to be killed upon sigint.
- Outputs to console upon sigint.
- Reports in JSON whether a run was canceled early.
- Moves analysis to finally, so it is still run when sigint is invoked.
…of finally, so that even early exits get analyzed, print new line in json to indicate if run exited early or not
jgiszczak
reviewed
Sep 27, 2022
| if completedRun: | ||
| assert transactionsSent == data.totalTransactions , f"Error: Transactions received: {data.totalTransactions} did not match expected total: {transactionsSent}" | ||
| else: | ||
| os.system("pkill trx_generator") |
There was a problem hiding this comment.
This is a candidate for replacing with explicit subprocess control, but we'll wait on that until the regression test harness has support for it.
jgiszczak
approved these changes
Sep 27, 2022
oschwaldp-oci
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.