Added IF ibc contract + test #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Mar 15, 2024
greg7mdp
reviewed
Mar 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
Note:start |
Fixed |
linh2931
approved these changes
Mar 18, 2024
greg7mdp
approved these changes
Mar 18, 2024
spoonincode
reviewed
Mar 18, 2024
| : num_bits(size), data((size + 63) / 64) {} | ||
|
|
||
| bitset(size_t size, const std::vector<uint64_t>& raw_bitset) | ||
| : num_bits(size), data(raw_bitset) {} |
There was a problem hiding this comment.
might want to consider validating that raw_bitset is properly sized. otherwise it seems like it's possible to construct a bitset where num_bits is greater than actual data.
…leap into hotstuff_integration
greg7mdp
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.