IF: add unit tests for finality_core #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Feb 27, 2024
unittests/finality_core_tests.cpp
Outdated
| { | ||
| test_core core; | ||
|
|
||
| // strong QC claim on block 4 will addvance LIB to 2 |
There was a problem hiding this comment.
Many occurences of this typo!
Suggested change
| // strong QC claim on block 4 will addvance LIB to 2 | |
| // strong QC claim on block 4 will advance LIB to 2 |
heifner
approved these changes
Feb 27, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the new finality_core. Strong, weak, and mixed QC claims are tested.
Resolved #2259.