Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade libsecp256k1 to 0.4.1 #2262

Merged
merged 1 commit into from
Feb 26, 2024
Merged

upgrade libsecp256k1 to 0.4.1 #2262

merged 1 commit into from
Feb 26, 2024
+1 −1

Conversation

spoonincode
Copy link
Member

Upgrade libsecp256k1 from 0.4.0 to 0.4.1. Release notes state,

Optional handwritten x86_64 assembly for field operations was removed because modern C compilers are able to output more efficient assembly. This change results in a significant speedup of some library functions when handwritten x86_64 assembly is enabled (--with-asm=x86_64 in GNU Autotools, -DSECP256K1_ASM=x86_64 in CMake), which is the default on x86_64. Benchmarks with GCC 10.5.0 show a 10% speedup for secp256k1_ecdsa_verify and secp256k1_schnorrsig_verify.

Indeed, the performance for a k1 key recovery improves from about 33µs to a little under 30µs on my hardware. A nice free performance boost.

@spoonincode spoonincode merged commit 35c8563 into main Feb 26, 2024
26 checks passed
@spoonincode spoonincode deleted the libsecp256k1-v041 branch February 26, 2024 21:51
@ericpassmore
Copy link
Contributor

Note:start
group: PERFORMANCE
category: INTERNALS
summary: Upgrade libsecp256k1 library for faster operations on keys.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoonincode @ericpassmore @greg7mdp @heifner