Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Replace websocketpp with boost beast #22

Merged
merged 11 commits into from
Aug 31, 2022

Conversation

ClaytonCalabrese
Copy link
Contributor

@ClaytonCalabrese ClaytonCalabrese commented Aug 18, 2022

Overhauls http_plugin, replacing websocketpp with boost::beast. Feature parity with previous implementation, with exception of new additions keep-alive/multiple requests per session and additional server-side error logging. Additional test in plugin_http_api_test for keep-alive.
EOSIO/eos#10583

Resolves eosnetworkfoundation/mandel#148

Previous discussions were had in the old repo:
eosnetworkfoundation/mandel#675

Will merge AntelopeIO/fc#4 and then update fc submodule.

@ClaytonCalabrese ClaytonCalabrese added the OCI Work exclusive to OCI team label Aug 18, 2022
@ClaytonCalabrese ClaytonCalabrese self-assigned this Aug 18, 2022
@spoonincode
Copy link
Member

Can you bump the fc submodule to the branch you have over in fc w/ websocketpp removed?

@spoonincode
Copy link
Member

I've been eyeballing this some and I think we should go ahead and get it in. Can you please get it synced to main, make sure anything related to #64 is taken care of, and bump the fc submodule.

@heifner
Copy link
Member

heifner commented Aug 31, 2022

@spoonincode If you are good we can merge AntelopeIO/fc#4 update this PR and then merge it.

Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep let's go ahead

@ClaytonCalabrese ClaytonCalabrese merged commit bc7edb6 into main Aug 31, 2022
@ClaytonCalabrese ClaytonCalabrese deleted the replace_websocketpp_with_boost_beast branch August 31, 2022 21:22
greg7mdp added a commit that referenced this pull request Dec 15, 2023
131/150 Test   #98: producer_schedule_hs_unit_test_eos-vm-jit ..........***Failed    1.36 sec
132/150 Test   #97: producer_schedule_hs_unit_test_eos-vm ..............***Failed    1.57 sec
133/150 Test   #96: producer_schedule_hs_unit_test_eos-vm-oc ...........***Failed    2.86 sec
144/150 Test   #21: api_unit_test_eos-vm-oc ............................***Failed   79.26 sec
146/150 Test   #23: api_unit_test_eos-vm-jit ...........................***Failed   96.61 sec
150/150 Test   #22: api_unit_test_eos-vm ...............................***Failed  467.14 sec
heifner added a commit that referenced this pull request Apr 29, 2024
IF: P2P: Send handshake to peer to let it know it is not syncing from peer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace websocketpp with boost beast as nodeos' HTTP server implemention
4 participants