IF: Test: Fix ship_streamer_test forking by using an explicit topo #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Feb 3, 2024
tests/TestHarness/Cluster.py
Outdated
| @@ -999,7 +999,7 @@ def activateInstantFinality(self, launcher, biosFinalizer, pnodes): | |||
| # call setfinalizer | |||
| numFins = 0 | |||
| for n in launcher.network.nodes.values(): | |||
| if n.keys[0].blspubkey is None: | |||
| if len(n.keys) == 0 or n.keys[0].blspubkey is None: | |||
There was a problem hiding this comment.
no big deal, but I think this is more idiomatic:
Suggested change
| if len(n.keys) == 0 or n.keys[0].blspubkey is None: | |
| if not n.keys or not n.keys[0].blspubkey: |
linh2931
approved these changes
Feb 3, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
ship_streamer_testby using a specifictopo. See comments in the test for specifics of the setup.Snapshot part of test depends on: #1558
Resolves #2172