Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Fix nodeos_retry_transaction_test.py #218

Merged
merged 2 commits into from
Sep 23, 2022
Merged

[3.1] Fix nodeos_retry_transaction_test.py #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc2fce
GH-217 Remove debug print causing log spam
heifner Sep 23, 2022
57fa42d
GH-217 transferFunds returns None on failure
heifner Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/nodeos_retry_transaction_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
overdrawTransferAmount = "1001.0000 {0}".format(CORE_SYMBOL)
Print("Transfer funds %s from account %s to %s" % (overdrawTransferAmount, overdrawAccount.name, cluster.eosioAccount.name))
overdrawtrans = node.transferFunds(overdrawAccount, cluster.eosioAccount, overdrawTransferAmount, "test overdraw transfer", exitOnError=False, reportStatus=False, retry=1)
assert "overdrawn balance" in str(overdrawtrans), "ERROR: Overdraw transaction attempt should have failed with overdrawn balance."
assert overdrawtrans is None, f"ERROR: Overdraw transaction attempt should have failed with overdrawn balance: {overdrawtrans}"

def cacheTransIdInBlock(transId, transToBlock, node):
global lastIrreversibleBlockNum
Expand Down
1 change: 0 additions & 1 deletion tests/testUtils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ def checkDelayedOutput(popen, cmd, ignoreError=False):
(output,error)=popen.communicate()
Utils.checkOutputFileWrite(start, cmd, output, error)
if popen.returncode != 0 and not ignoreError:
Utils.Print("ERROR: %s" % error)
# for now just include both stderr and stdout in output, python 3.5+ supports both a stdout and stderr attributes
raise subprocess.CalledProcessError(returncode=popen.returncode, cmd=cmd, output=error+bytes(" ", 'utf-8')+output)
return output.decode("utf-8")
Expand Down