upgrade to actions/upload-artifact@v4
#2140
Merged
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jan 25, 2024
greg7mdp
approved these changes
Jan 25, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to
actions/upload-artifact@v4. This has a couple nice benefits (as advertised by v4),Upload performance is substantially better than v3, so much so that we can get rid of my
upload-artifact-large-chunks-actionand just rely on the canonicalupload-artifactgoing forward.More interestingly, artifacts are viewable and downloadable before the workflow completes. This has long been an annoyance to me so great to see this resolved. It's nice to, for example, grab the build or the leap-dev or some logs before the entire workflow has completed (i.e. before LR tests take.. a long time to complete). It'll also be hugely beneficial to usages of
asset-artifact-download-actionfor similar reasons. For example, a workflow that's still in progress but has a leap-dev.deb completed can be used immediately instead of waiting for LR tests to complete. Sadly, I believe,asset-artifact-download-actionwill need to be refactored to deal with this new possibility (I believe it waits for the workflow to be completed currently). Maybe one day..