Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Changes in controller to complete unification #2052

Merged
merged 19 commits into from
Jan 9, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Jan 7, 2024

Will eventually address #2034 .

This is a work in progress... but still would like to check it in to unblock Lin and Kevin.

@greg7mdp greg7mdp changed the base branch from main to hotstuff_integration January 7, 2024 04:04
@greg7mdp greg7mdp marked this pull request as draft January 7, 2024 04:04
@greg7mdp greg7mdp marked this pull request as ready for review January 8, 2024 21:24
@greg7mdp greg7mdp requested review from linh2931 and heifner January 8, 2024 21:25

emplace_extension(result.header.header_extensions, instant_finality_extension::extension_id(),
fc::raw::pack(instant_finality_extension{qc_info,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::move?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The qc_info is just an int and a bool, so std::move doesn't make a difference, which is why I didn't add it.

@greg7mdp greg7mdp merged commit b335157 into hotstuff_integration Jan 9, 2024
@greg7mdp greg7mdp deleted the gh_2034 branch January 9, 2024 03:59
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Refactor of controller to support both Faster Finality and Legacy Block Finalization.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Unification: Changes in controller to complete unification
4 participants