-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Changes in controller to complete unification #2052
Conversation
…ck if if is active.
|
||
emplace_extension(result.header.header_extensions, instant_finality_extension::extension_id(), | ||
fc::raw::pack(instant_finality_extension{qc_info, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::move?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The qc_info
is just an int
and a bool
, so std::move
doesn't make a difference, which is why I didn't add it.
Note:start |
Will eventually address #2034 .
This is a work in progress... but still would like to check it in to unblock Lin and Kevin.