-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mandel and https://github.com/eosnetworkfoundation references in leap #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest just bringing in the remaining two submodule commit updates from #3 into here as well. I didn't understand the reasoning in the description for why they should be included as part of a separate PR.
Also, there are still mandel references in tutorials/bios-boot-tutorial/README.md
. Some of them we won't be able to remove at this time like mandel-contracts
. But you can do the Leap and CDT replacement.
README.md
Outdated
@@ -1,14 +1,14 @@ | |||
# Mandel | |||
# Leap | |||
|
|||
Home of the official [EOS Network Foundation](https://eosnetwork.com/) blockchain node software. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should at least be modified to include it's an implementation of Antelope. Similar to the packaging "C++ implementation of the Antelope protocol", but more prose.
Sorry I missed |
…l/README.md, use Leap (not leap) for noun, and several small changes
Provide leap named CMake files in build directory and dev package as preferred way for other projects to use Leap as a dependency. License files now installed in folder named leap rather than eosio.
LGTM. Looking for someone to review my commits though.
I pulled in latest changes, deleted my build directory, and am rebuilding from scratch. Will review your commits late tonight. |
Your commits look fine. My fresh build of Leap and system contracts with |
regenerate deepmind log for new BLS_PRIMITIVES
Changes are
mandel
,Mandel
, andMANDEL
with correspondingleap
equivalentshttps://github.com/eosnetworkfoundation
withhttps://github.com/AntelopeIO