IF: update libtester eosio.bios to match latest eosio.bios in reference-contracts, add more validation to set_finalizers host function #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontract, add more valiation to set_finalizers host function
heifner
requested changes
Dec 14, 2023
greg7mdp
requested changes
Dec 14, 2023
Comment on lines
58
to
59
| check(f.public_key.substr(0, pk_prefix.length()) == pk_prefix, "public key not started with PUB_BLS"); | ||
| check(f.pop.substr(0, sig_prefix.length()) == sig_prefix, "proof of possession signature not started with SIG_BLS"); |
There was a problem hiding this comment.
Suggested change
| check(f.public_key.substr(0, pk_prefix.length()) == pk_prefix, "public key not started with PUB_BLS"); | |
| check(f.pop.substr(0, sig_prefix.length()) == sig_prefix, "proof of possession signature not started with SIG_BLS"); | |
| check(f.public_key.substr(0, pk_prefix.length()) == pk_prefix, "public key should start with PUB_BLS"); | |
| check(f.pop.substr(0, sig_prefix.length()) == sig_prefix, "proof of possession signature should start with SIG_BLS"); |
There was a problem hiding this comment.
Many of our error messages state the fact of error. Not sure which way is clearer. Will change.
There was a problem hiding this comment.
If this is changed it needs to be updated in reference contracts. Not sure it is worth it for bios contract.
There was a problem hiding this comment.
Probably it is not worthwhile for now.
There was a problem hiding this comment.
I don't believe the current message is correct English.
There was a problem hiding this comment.
Reference Contracts changes will be done by AntelopeIO/reference-contracts#34
| abi_finalizer_policy.finalizers.emplace_back(eosio::abi_finalizer_authority{f.description, f.weight, std::move(pk_vector)}); | ||
| } | ||
|
|
||
| check(finalizer_policy.threshold > weight_sum / 2, "finalizer policy threshold cannot be met by finalizer weights"); |
There was a problem hiding this comment.
Suggested change
| check(finalizer_policy.threshold > weight_sum / 2, "finalizer policy threshold cannot be met by finalizer weights"); | |
| check(finalizer_policy.threshold > weight_sum / 2, "finalizer policy threshold must be greater than half of the sum of the weights"); |
…wasm_parser to resolve env.bls_fp_mod unresolveable
heifner
reviewed
Dec 15, 2023
…sistent with underlying types
…earlier and report the offending public key if duplicate key is detected
heifner
reviewed
Dec 15, 2023
heifner
approved these changes
Dec 18, 2023
greg7mdp
approved these changes
Dec 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port latest
eosio.biosfrom #1987 to libtester, add POP check, and update tests.In
set_finalizershost function, add overflow check forf_weight_sumand always validate public key.Resolved #1987