Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] (chainbase) use free() -- not delete -- for aligned_alloc() pointer #1978

Merged
merged 2 commits into from
Dec 22, 2023
Merged

[5.0] (chainbase) use free() -- not delete -- for aligned_alloc() pointer #1978

merged 2 commits into from
Dec 22, 2023

Conversation

spoonincode
Copy link
Member

Bumps chainbase submodule to fix a compile & ASAN warning, see: AntelopeIO/chainbase#32

@greg7mdp
Copy link
Contributor

should be std::free().

@spoonincode spoonincode merged commit 574f430 into release/5.0 Dec 22, 2023
29 checks passed
@spoonincode spoonincode deleted the cb_alloc_delete_free_fix_5x branch December 22, 2023 01:17
@spoonincode spoonincode mentioned this pull request Dec 22, 2023
Merged
@ericpassmore
Copy link
Contributor

Note:start
group: Chainbase
category: PERF_EFFICIENCY
summary: Bumps chainbase submodule to fix a compile & ASAN warning
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spoonincode @greg7mdp @ericpassmore @heifner @linh2931