-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Add /v1/chain/get_unapplied_transactions to producer_api_plugin #182
Conversation
/v1/chain/get_unapplied_transaction
s to producer_api_plugin
/v1/chain/get_unapplied_transactions
to producer_api_plugin
/v1/chain/get_unapplied_transactions
to producer_api_plugin
Updated openapi updates producer.swagger.yaml |
result.size = ua.size(); | ||
result.incoming_size = ua.incoming_size(); | ||
|
||
uint32_t remaining = p.limit ? *p.limit : std::numeric_limits<uint32_t>::max(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaulting to max seems big. Not sure what is typical, I would have made the default a max of short int, uint16. Max should be bigger up to unit32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is limited by the time_limit_ms
, setting limit
to max uint32 just means it is limited by time only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah one sec
Add
/v1/chain/get_unapplied_transactions
toproducer_api_plugin
Interface:
Resolves #109
Example use: