Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1 -> main] pinned_build.sh: make relative path work #180

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

linh2931
Copy link
Member

main branch merge of #179.
Resolve #130.

Two issues prevents relative paths from working:

  1. if [[ ${D} != ${EXPECTED} ]]; then does string comparison. ../lib != /home/lib even though they refer to the same directory.
  2. After the first problem was fixed, a second error occurred in cmake:
 The CMAKE_C_COMPILER:
    ../lib/clang-11.0.1/bin/clang
  is not a full path and was not found in the PATH.

After the fix,

./scripts/pinned_build.sh ../lib ./build 6 produces

...
CPackDeb: - Generating dependency list
 .----------------.  .----------------.  .----------------.  .----------------.
| .--------------. || .--------------. || .--------------. || .--------------. |
| |   _____      | || |  _________   | || |      __      | || |   ______     | |
| |  |_   _|     | || | |_   ___  |  | || |     /  \     | || |  |_   __ \   | |
| |    | |       | || |   | |_  \_|  | || |    / /\ \    | || |    | |__) |  | |
| |    | |   _   | || |   |  _|  _   | || |   / ____ \   | || |    |  ___/   | |
| |   _| |__/ |  | || |  _| |___/ |  | || | _/ /    \ \_ | || |   _| |_      | |
| |  |________|  | || | |_________|  | || ||____|  |____|| || |  |_____|     | |
| |              | || |              | || |              | || |              | |
| '--------------' || '--------------' || '--------------' || '--------------' |
Leap has successfully built and constructed its packages.  You should be able to find the packages at ./build.  Enjoy!!!

@linh2931 linh2931 merged commit 471b08e into main Sep 16, 2022
@linh2931 linh2931 deleted the fix_relative_path_main branch September 16, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned build: relative directories don't work
2 participants